refactor: Trigger UserFirstTimeLoggedIn instead of manually copying skeleton#1428
Draft
CarlSchwan wants to merge 1 commit intomainfrom
Draft
refactor: Trigger UserFirstTimeLoggedIn instead of manually copying skeleton#1428CarlSchwan wants to merge 1 commit intomainfrom
CarlSchwan wants to merge 1 commit intomainfrom
Conversation
8 tasks
…keleton Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/copySkeleton
branch
from
f0523d1 to
6152c23
Compare
come-nc
reviewed
Apr 28, 2026
| private UserMapper $userMapper, | ||
| private IUserManager $userManager, | ||
| private IEventDispatcher $eventDispatcher, | ||
| private IConfig $config, |
Contributor
There was a problem hiding this comment.
import is missing.
Also you may want to use ServerVersion?
come-nc
reviewed
Apr 28, 2026
Comment on lines
+72
to
+74
| // Slighly incorrect, but this event trigger the creation of the file skeleton and | ||
| // the contact book entry. | ||
| $this->eventDispatcher->dispatchTyped(new UserFirstTimeLoggedInEvent($user)); |
Contributor
There was a problem hiding this comment.
It is incorrect, we should not trigger this event unless the user logs in.
But with oidc if it’s created it means he’s currently logging in?
Member
|
Keep in mind this app supports NC 29 -> 34. I am not against having branches but considering the number of times we have to make fixes/releases for old NC versions, I would recommend not having one branch per server stable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need nextcloud/server#59932 first